fix: add fire lines support for streaming/protobuf playback mode#122
Merged
fix: add fire lines support for streaming/protobuf playback mode#122
Conversation
Fire lines (projectile trajectories) were not appearing when using streaming mode with protobuf format because: 1. The protobuf schema lacked framesFired data for entities 2. The streaming mode playback loop didn't include fire line drawing 3. getLatLng() couldn't retrieve entity positions in streaming mode Changes: - Add FiredFrame message to protobuf schema (ocap.proto) - Update parser to extract framesFired from JSON recordings - Update protobuf writer to include framesFired in manifest - Update frontend decoder to read framesFired from protobuf - Add fire line drawing code to streaming mode playback loop - Fix getLatLng() to return marker position in streaming mode - Fix off-by-one bug in firedOnFrame() loop condition
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
framesFiredsupport to protobuf schema and updated all layers of the stackgetLatLng()to work correctly in streaming modeRoot Causes
framesFireddata for entitiesgetLatLng()tried to read from empty_positionsarray in streaming mode instead of getting position from markerfiredOnFrame()loop condition wasi < length - 1instead ofi < lengthChanges
Backend
FiredFramemessage to protobuf schema (ocap.proto)FiredFramestruct andFramesFiredfield toEntityDef(engine.go)framesFiredfrom JSON recordings (parser_v1.go)framesFiredin manifest (writer_protobuf_v1.go)Frontend
framesFiredfield (protobuf.js)ocap.js)getLatLng()to return marker position in streaming mode (ocap.entity.js)firedOnFrame()loop condition (ocap.unit.js)Test plan